RFR: 8364235: Fix for JDK-8361447 breaks the alignment requirements for GuardedMemory [v2]
    David Holmes 
    dholmes at openjdk.org
       
    Wed Jul 30 06:47:56 UTC 2025
    
    
  
On Tue, 29 Jul 2025 08:30:42 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Correct comments as per reviewer comments
>
> src/hotspot/share/memory/guardedMemory.hpp line 45:
> 
>> 43:  * |------------------------------------------------------------
>> 44:  * |base_addr          | 0xABABABABABABABAB   | Head guard     |
>> 45:  * |+16                | padding              | For alignment  |
> 
> Is `+sizeof(Guard)` or `+GUARD_SIZE` an alternative to `+16`. 16 is a little out of the blue for me.
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26524#discussion_r2241688266
    
    
More information about the hotspot-runtime-dev
mailing list