RFR: 8364359: Sort share/cds includes
Francesco Andreuzzi
duke at openjdk.org
Wed Jul 30 17:39:56 UTC 2025
On Wed, 30 Jul 2025 17:10:45 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> Is this auto-generated order?
No, I moved `errno.h` and `sys/stat.h` manually.
> The Style Guide says: [...]
So the expected order is:
- hotspot includes
- hotspot conditional includes
- system includes
- system conditional includes
I got a comment about include order in another PR, and I interpreted it as "conditional includes always at the bottom". Happy to have it clarified now, I'll push another commit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26561#discussion_r2243431025
More information about the hotspot-runtime-dev
mailing list