RFR: 8364359: Sort share/cds includes [v2]
Aleksey Shipilev
shade at openjdk.org
Wed Jul 30 17:48:55 UTC 2025
On Wed, 30 Jul 2025 17:40:16 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:
>>> Is this auto-generated order?
>>
>> No, I moved `errno.h` and `sys/stat.h` manually.
>>
>>> The Style Guide says: [...]
>>
>> So the expected order is:
>> - hotspot includes
>> - hotspot conditional includes
>> - system includes
>> - system conditional includes
>>
>> I got a comment about include order in another PR, and I interpreted it as "conditional includes always at the bottom". Happy to have it clarified now, I'll push another commit.
>
> 485177eb34e1ef76cf940b5860350ab5fcdc8cdc
> So the expected order is:
Yes, this is my interpretation of the guide, and I think this is the established style.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26561#discussion_r2243454032
More information about the hotspot-runtime-dev
mailing list