RFR: 8364359: Sort share/cds includes [v2]

Aleksey Shipilev shade at openjdk.org
Thu Jul 31 12:33:56 UTC 2025


On Wed, 30 Jul 2025 17:43:09 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:

>> This PR sorts the includes in `hotspot/share/cds` using `SortIncludes.java`. I'm also adding the directory to `TestIncludesAreSorted`.
>> 
>> Passes tier1.
>
> Francesco Andreuzzi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   system includes below

Looks good to me with a minor nit. But I have missed things before, so someone else needs to take a look as well. For example @iklam or @calvinccheung, who are often in this area.

test/hotspot/jtreg/sources/TestIncludesAreSorted.java line 49:

> 47:                     "share/c1",
> 48:                     "share/ci",
> 49:                     "share/cds",

Unordered: `cds` < `ci`?

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26561#pullrequestreview-3075203723
PR Review Comment: https://git.openjdk.org/jdk/pull/26561#discussion_r2245250011


More information about the hotspot-runtime-dev mailing list