RFR: 8351661: NMT: VMATree should support separate call-stacks for reserve and commit operations [v33]
Afshin Zafari
azafari at openjdk.org
Mon Jun 2 09:15:00 UTC 2025
On Sun, 1 Jun 2025 06:49:39 GMT, Afshin Zafari <azafari at openjdk.org> wrote:
>> test/hotspot/gtest/nmt/test_vmatree.cpp line 3211:
>>
>>> 3209: // 1 2 3 4 5
>>> 3210: // 012345678901234567890123456789012345678901234567890
>>> 3211: // rrrrrrrrrr..........rrrrrrrrrr
>>
>> What is this comment supposed to show?
>>
>> I cleaned up, some comments and created a branch https://github.com/openjdk/jdk/compare/master...gerard-ziemski:jdk:gerard-8351661 in case you want to see it.
>
> The comment is removed.
>
> In the branch you sent the link, almost all of the new format comments are removed. Is that correct?
The extra grabage-like comments are all removed. They came after running a script for putting comments in the code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24028#discussion_r2120528237
More information about the hotspot-runtime-dev
mailing list