RFR: 8352187: Don't start management agent during AOT cache creation [v2]
Aleksey Shipilev
shade at openjdk.org
Mon Jun 2 16:50:14 UTC 2025
On Mon, 2 Jun 2025 16:46:51 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> If a management agent is specified when creating an AOT cache, it resulted in `java.lang.IllegalArgumentException`.
>> To avoid the exception, this fix is not to start the management agent when creating an AOT cache.
>>
>> Passed tiers 1 - 4 testing.
>
> Calvin Cheung has updated the pull request incrementally with two additional commits since the last revision:
>
> - Update test/hotspot/jtreg/runtime/cds/appcds/aotCache/ManagementAgent.java
>
> Co-authored-by: Aleksey Shipilëv <shipilev at amazon.de>
> - place the new test in a new file
Marked as reviewed by shade (Reviewer).
Marked as reviewed by shade (Reviewer).
test/hotspot/jtreg/runtime/cds/appcds/aotCache/ManagementAgent.java line 44:
> 42: public class ManagementAgent {
> 43: public static void main(String... args) throws Exception {
> 44: SimpleCDSAppTester.of("HelloAOTCache-with-manangment-agent")
Suggestion:
SimpleCDSAppTester.of("HelloAOTCache-with-management-agent")
-------------
PR Review: https://git.openjdk.org/jdk/pull/25562#pullrequestreview-2889202582
PR Review: https://git.openjdk.org/jdk/pull/25562#pullrequestreview-2889216659
PR Review Comment: https://git.openjdk.org/jdk/pull/25562#discussion_r2121669853
More information about the hotspot-runtime-dev
mailing list