RFR: 8357914: TestEmptyBootstrapMethodsAttr.java fails when run with TEST_THREAD_FACTORY=Virtual

[David Holmes]

On Wed, 4 Jun 2025 20:00:09 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> test/hotspot/jtreg/runtime/classFileParserBug/TestEmptyBootstrapMethodsAttr.java line 58:
>> 
>>> 56:         output.shouldNotContain("java.lang.ClassFormatError");
>>> 57:         output.shouldHaveExitValue(1);
>>> 58:         if (Thread.currentThread().isVirtual()) {
>> 
>> Just to be clear with `TEST_THREAD_FACTORY=Virtual` are all launched JVMs modified such that a virtual thread is created to invoke "main" instead of the normal platform thread? It just isn't clear why being virtual in the parent VM implies the child was also virtual, unless everything is virtual.
>> 
>> FWIW I think this highlights a deficiency with how TEST_THREAD_FACTORY=Virtual actually works.
>
> @dholmes-ora @lmesnik are you okay with my suggestion above?

As long as `command()` returns the information reliably (could it be set via an env-var instead?) then it seems reasonable to check the child process directly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25509#discussion_r2127883503