RFR: 8358556: Assert when running with -XX:-UseLibmIntrinsic [v2]

[Sandhya Viswanathan]

On Fri, 6 Jun 2025 21:10:11 GMT, Mohamed Issa <duke at openjdk.org> wrote:

>> This change fixes unwanted calls to the cbrt and tanh intrinsics on x86 when they are explicitly disabled by the _-XX:-UseLibmIntrinsic_ or _-XX:-InlineIntrinsics_ flags.
>
> Mohamed Issa has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Move UseLibmIntrinsic flag to x86 portion of code base to avoid build breaks

src/hotspot/share/classfile/vmIntrinsics.cpp line 263:

> 261:     switch (id) {
> 262:     case vmIntrinsics::_dtanh:
> 263:     case vmIntrinsics::_dcbrt:

You could also move _floatToFloat16 and _float16ToFloat to here from the switch below to make it consistent.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25680#discussion_r2133035942