RFR: 8357632: CDS test failures on static JDK
Jiangli Zhou
jiangli at openjdk.org
Fri Jun 6 23:15:51 UTC 2025
On Fri, 6 Jun 2025 19:22:47 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> Please review the fix in CDSConfig::default_archive_path to form the default .jsa path using Arguments::get_java_home on static-jdk. It basically reverts to the previous code before JDK-8353504, but for static-jdk case only. The change does not affect how default .jsa path is handled on regular JDK.
>>
>> The PR removes the affected CDS tests from hotspot/jtreg/ProblemList-StaticJdk.txt.
>>
>> It adds '@requires !jdk.static' to runtime/cds/NonJVMVariantLocation.java to skip the test on static-jdk. NonJVMVariantLocation.java tests with VM variants specified in jvm.cfg, which is not processed on static-jdk.
>>
>> Testing:
>> Tested the affected tests locally on static-jdk.
>> https://github.com/jianglizhou/jdk/actions/runs/15312986693 is in progress.
>
> Looks good. Thanks!
@calvinccheung Thanks for the review!
Can I have a second review for the PR, thanks!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25516#issuecomment-2951175735
More information about the hotspot-runtime-dev
mailing list