RFR: 8358556: Assert when running with -XX:-UseLibmIntrinsic [v3]

[Sandhya Viswanathan]

On Fri, 6 Jun 2025 23:33:05 GMT, Mohamed Issa <duke at openjdk.org> wrote:

>> This change fixes unwanted calls to the cbrt and tanh intrinsics on x86 when they are explicitly disabled by flags such as _-XX:-UseLibmIntrinsic_ or _-XX:-InlineIntrinsics_.
>
> Mohamed Issa has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Re-structure logic to avoid reliance on UseLibmIntrinsic flag as others could be used later on

src/hotspot/share/classfile/vmIntrinsics.cpp line 319:

> 317:   case vmIntrinsics::_dtanh:
> 318:   case vmIntrinsics::_dcbrt:
> 319:     if (!InlineMathNatives) return true;

Ah, looks like you missed !InlineIntrinsic check here:
if (!InlineMathNatives || !InlineIntrinsics) return true;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25680#discussion_r2133077192