RFR: 8358556: Assert when running with -XX:-UseLibmIntrinsic [v3]

[Mohamed Issa]

On Fri, 6 Jun 2025 23:41:27 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Mohamed Issa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Re-structure logic to avoid reliance on UseLibmIntrinsic flag as others could be used later on
>
> src/hotspot/share/classfile/vmIntrinsics.cpp line 319:
> 
>> 317:   case vmIntrinsics::_dtanh:
>> 318:   case vmIntrinsics::_dcbrt:
>> 319:     if (!InlineMathNatives) return true;
> 
> Ah, looks like you missed !InlineIntrinsic check here:
> if (!InlineMathNatives || !InlineIntrinsics) return true;

Yes, I was thinking to fall through to the cases below, but I missed the break statement. It's clearer with the extra check anyway, so I added it in now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25680#discussion_r2133135956