RFR: 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform [v8]
David Holmes
dholmes at openjdk.org
Mon Jun 9 03:42:00 UTC 2025
On Fri, 6 Jun 2025 08:21:08 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:
>> To resolve runtime/os/windows/TestAvailableProcessors.java failure, I made "systeminfo.exe" executed with "chcp 437". This ensures that the English message "OS Version: " is output on localized windows platforms.
>> I added the path C:\Windows\System32 to make chcp command recognized on the GHA Windows test machine. Without this addition, GHA will fail.
>> After this fix, I verified that the test passed.
>>
>> https://github.com/openjdk/jdk/pull/22142
>> I refer to this fix.
>> tools/jpackage/windows/Win8301247Test.java does not run in GHA, so the problems with recognition of chcp command did not occur before.
>>
>> Thanks.
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
>
> 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform
Thanks for update. Nothing further from me.
As we are passed RDP1 this will get commited into JDK 26, but as a test fix it is also eligible to be backported to JDK 25 if you chose.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23536#pullrequestreview-2908848940
More information about the hotspot-runtime-dev
mailing list