RFR: 8358556: Assert when running with -XX:-UseLibmIntrinsic [v4]
Sandhya Viswanathan
sviswanathan at openjdk.org
Mon Jun 9 18:34:52 UTC 2025
On Sat, 7 Jun 2025 00:57:25 GMT, Mohamed Issa <duke at openjdk.org> wrote:
>> This change fixes unwanted calls to the cbrt and tanh intrinsics on x86 when they are explicitly disabled by flags such as _-XX:-UseLibmIntrinsic_ or _-XX:-InlineIntrinsics_.
>
> Mohamed Issa has updated the pull request incrementally with one additional commit since the last revision:
>
> Add extra check for InlineIntrinscs flag
src/hotspot/share/classfile/vmIntrinsics.cpp line 319:
> 317: case vmIntrinsics::_dtanh:
> 318: case vmIntrinsics::_dcbrt:
> 319: if (!InlineMathNatives || !InlineIntrinsics) return true;
You also need to add check for UseLibmIntrinsic here:
#ifdef AMD64
if (!UseLibmIntrinsic) return true;
#endif
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25680#discussion_r2136250496
More information about the hotspot-runtime-dev
mailing list