RFR: 8357862: Java argument file is parsed unexpectedly with trailing comment

Christian Stein cstein at openjdk.org
Tue Jun 10 08:18:34 UTC 2025


On Mon, 2 Jun 2025 16:03:49 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> right I agree that if there is common code we should extract it in a helper method
>
> Or the handling of `#` can be merged with the previous case ... somehow.

Extracting a method wouldn't really simplify the code, as many local variables are in play.

Merging the cases also ends up in more if-else constructs in the case block that counter-act readability.

So, perhaps, the duplication is goog-enough here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25589#discussion_r2137227216


More information about the hotspot-runtime-dev mailing list