RFR: 8265754: Move suspend/resume API from HandshakeState [v9]

[Anton Artemov]

On Mon, 9 Jun 2025 16:18:42 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8265754: Changed handshakee to target.
>
> src/hotspot/share/runtime/suspendResumeManager.hpp line 27:
> 
>> 25: #ifndef SHARE_RUNTIME_SUSPENDRESUMEMANAGER_HPP
>> 26: #define SHARE_RUNTIME_SUSPENDRESUMEMANAGER_HPP
>> 27: 
> 
> We need to add `class SuspendThreadHandshake;` and `class ThreadSelfSuspensionHandshake;` here (currently relying on the declarations in handshake.hpp).

Addressed in the latest commit.

> src/hotspot/share/runtime/suspendResumeManager.hpp line 37:
> 
>> 35: 
>> 36: public:
>> 37:   SuspendResumeManager(JavaThread* thread, Monitor* state_lock);
> 
> Maybe this should also be private given that `JavaThread` is a friend already?

Makes sense. Addressed in the latest commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25407#discussion_r2137277127
PR Review Comment: https://git.openjdk.org/jdk/pull/25407#discussion_r2137277820