RFR: 8358799: Refactor os::jvm_path() [v2]
David Holmes
dholmes at openjdk.org
Tue Jun 10 13:04:32 UTC 2025
On Mon, 9 Jun 2025 19:01:57 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> The linux, bsd, and aix versions of os::jvm_path() are very similar and can be combined into one in os_posix.cpp.
>>
>> Passed tiers 1 - 3 tests.
>> However, tests were not run on the aix platform since it is not one of the Oracle supported platforms.
>
> Calvin Cheung has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - review comments from @dholmes-ora and @jdksjolen
> - Merge branch 'master' into 8358799-refactor-jvm-path
> - 8358799: Refactor os::jvm_path()
I'd still like some input from AIX folk on whether we can do better here, but in lieu of that this seems good enough to me.
Thanks
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25675#pullrequestreview-2913479876
More information about the hotspot-runtime-dev
mailing list