RFR: 8265754: Move suspend/resume API from HandshakeState [v11]
Coleen Phillimore
coleenp at openjdk.org
Wed Jun 11 12:45:54 UTC 2025
On Tue, 10 Jun 2025 08:40:53 GMT, Anton Artemov <duke at openjdk.org> wrote:
>> Hi,
>>
>> in this PR the suspend/resume methods are moved away from the HandshakeState class into a new separate class SuspendResumeManager. The idea is that the state class should be a state keeper and should not be responsible for actions which change the state. Such actions should be done by a separate class.
>>
>> Tested in tiers 1-4.
>
> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>
> 8265754: Addressed reviewers comments.
Just needs a copyright fix.
src/hotspot/share/runtime/suspendResumeManager.cpp line 2:
> 1: /*
> 2: * Copyright (c) 2017, 2025, Oracle and/or its affiliates. All rights reserved.
Suggestion:
* Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
src/hotspot/share/runtime/suspendResumeManager.hpp line 2:
> 1: /*
> 2: * Copyright (c) 2017, 2025, Oracle and/or its affiliates. All rights reserved.
Suggestion:
* Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
-------------
Marked as reviewed by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25407#pullrequestreview-2916964481
PR Review Comment: https://git.openjdk.org/jdk/pull/25407#discussion_r2140025045
PR Review Comment: https://git.openjdk.org/jdk/pull/25407#discussion_r2140024252
More information about the hotspot-runtime-dev
mailing list