RFR: 8359110: Log accumulated GC and process CPU time upon VM exit [v3]

[Jonas Norlinder]

On Fri, 13 Jun 2025 09:55:38 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Jonas Norlinder has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Refactor shared logic into CollectedHeap, remove nominal logging and cost->usage
>>  - Remove unnecessary assert
>
> src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp line 164:
> 
>> 162: 
>> 163: void ParallelScavengeHeap::stop() {
>> 164:   log_gc_vtime();
> 
> I think in OO-fashion, instead of adding the `log_gc_vtime()` call everywhere, it should be called in the super-class method and the others defer to it.

Just wanna double-check that I understood your suggestion. Are you suggesting that we should rather add calls to `CollectedHeap::stop()` at the beginning of the specialization?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25779#discussion_r2145239880