RFR: 8358738: AOT cache created without graal jit should not be used with graal jit [v2]

[Calvin Cheung]

On Thu, 12 Jun 2025 22:02:43 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> We can't mix generation and usage of AOT cache when different JIT compilers are used (C2 vs Graal). Graal does different profiling settings and generate different code. We can only allow mix with Interpreter.
>> 
>> Record used compiler type in archive and check it when using archive.
>> 
>> Tested with tiers which use Graal.
>
> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address comments

Looks good. I have one question.

src/hotspot/share/cds/filemap.cpp line 1952:

> 1950:                             (compiler_type == CompilerType::compiler_none);
> 1951:   if (!intepreter_is_used &&
> 1952:       jvmci_compiler_is_enabled != (archive_compiler_type == CompilerType::compiler_jvmci)) {

Does it mean we allow different compiler type during assembly phase and production phase? e.g. assembly phase using c1, production phase using c2?

-------------

PR Review: https://git.openjdk.org/jdk/pull/25782#pullrequestreview-2925191023
PR Review Comment: https://git.openjdk.org/jdk/pull/25782#discussion_r2145312369