RFR: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead [v4]
Dean Long
dlong at openjdk.org
Mon Jun 16 23:45:57 UTC 2025
On Mon, 16 Jun 2025 00:48:40 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:
>> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove is_sigill_not_entrant
>
> src/hotspot/share/gc/z/zBarrierSetNMethod.cpp line 109:
>
>> 107: }
>> 108:
>> 109: void ZBarrierSetNMethod::arm_with(nmethod* nm, int value) {
>
> I don't usually comment on names, but could we call this guard_with instead? We tried to stop saying "arm" about things used also for disarming and we have (hopefully) been consistent about calling that "guard" instead.
Good suggestion. Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25764#discussion_r2151070290
More information about the hotspot-runtime-dev
mailing list