RFR: 8359110: Log accumulated GC and process CPU time upon VM exit [v5]

David Holmes dholmes at openjdk.org
Tue Jun 17 05:49:31 UTC 2025


On Mon, 16 Jun 2025 09:17:05 GMT, Jonas Norlinder <duke at openjdk.org> wrote:

>> Jonas Norlinder has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add CPU time tracking for string deduplication to log_gc_vtime
>
> src/hotspot/share/runtime/vmThread.cpp line 278:
> 
>> 276:     PerfTraceTime vm_op_timer(perf_accumulated_vm_operation_time());
>> 277:     HOTSPOT_VMOPS_BEGIN(
>> 278:                      (char *) op->name(), strlen(op->name()),
> 
> @dholmes-ora given that I'm editing `VMThread::evaluate_operation` and your comments about code style - do you want me to also change this type cast to `(char*)` to align with the preferred style?

Please do. Thanks

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25779#discussion_r2151372297


More information about the hotspot-runtime-dev mailing list