RFR: 8359959: Test runtime/NMT/VirtualAllocTestType.java failed: '\\[0x[0]*7f7dc4043000 - 0x[0]*7f7dc4083000\\] reserved 256KB for Test' missing from stdout/stderr [v2]

Afshin Zafari azafari at openjdk.org
Thu Jun 19 12:55:28 UTC 2025


On Thu, 19 Jun 2025 12:24:12 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   another approach.
>
> test/hotspot/jtreg/runtime/NMT/VirtualAllocTestType.java line 66:
> 
>> 64:       // If the second mapping happens to be adjacent to the first mapping, reserve another mapping and release the second mapping; for
>> 65:       // this test, we want to see two disjunct mappings.
>> 66:       if ((addr2 == addr1 + reserveSize) || (addr2 + reserveSize == addr1)) {
> 
> Suggestion:
> 
>       if ((addr2 == addr1 + reserveSize) || (addr2 == addr1 - reserveSize)) {
> 
> I find this formulation somewhat clearer in indicating `addr2` is adjacent after, or adjacent before `addr1`.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25894#discussion_r2156959698


More information about the hotspot-runtime-dev mailing list