RFR: 8295851: Do not use ttyLock in BytecodeTracer::trace [v2]

Coleen Phillimore coleenp at openjdk.org
Fri Jun 20 12:52:09 UTC 2025


> This didn't need ttyLock for synchronization, the code only needs to see if the method changes so it can print the method name before the bytecodes, like:
> 
> [490166] static void java.lang.String.<clinit>()
> [490166]       13    18  putstatic 613 <java/lang/String.CASE_INSENSITIVE_ORDER:Ljava/util/Comparator;>
> [490166]       14    21  return
> 
> [490166] static void java.lang.System.<clinit>()
> [490166]       15     0  invokestatic 471 <java/lang/System.registerNatives()V>
> [490166]       16     3  aconst_null
> [490166]       17     4  putstatic 474 <java/lang/System.in:Ljava/io/InputStream;>
> 
> Verified manually and added some parallelism to the test, and fixed trace() to initialize is_linked(), which it always is.
> Also ran tier1-4.

Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:

  Put back include osthread.hpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25915/files
  - new: https://git.openjdk.org/jdk/pull/25915/files/29b71ba5..0e4421be

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25915&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25915&range=00-01

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/25915.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25915/head:pull/25915

PR: https://git.openjdk.org/jdk/pull/25915


More information about the hotspot-runtime-dev mailing list