RFR: 8295851: Do not use ttyLock in BytecodeTracer::trace [v3]
Coleen Phillimore
coleenp at openjdk.org
Tue Jun 24 12:30:11 UTC 2025
On Tue, 24 Jun 2025 02:50:52 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Put back include osthread.hpp
>
> src/hotspot/share/interpreter/bytecodeTracer.cpp line 186:
>
>> 184: void BytecodeTracer::trace_interpreter(const methodHandle& method, address bcp, uintptr_t tos, uintptr_t tos2, outputStream* st) {
>> 185: if (TraceBytecodes && BytecodeCounter::counter_value() >= TraceBytecodesAt) {
>> 186: BytecodePrinter printer(_current_method);
>
> You need a `Atomic::load_acquire` here to pair with the `Atomic::release_store` below.
ok, added and changed the name of current_method, and added comments. Hope it helps.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25915#discussion_r2163855972
More information about the hotspot-runtime-dev
mailing list