RFR: 8360178: TestArguments.atojulong gtest has incorrect format string [v2]

Kim Barrett kbarrett at openjdk.org
Tue Jun 24 15:23:45 UTC 2025


> Please review this fix for the format directive when printing ULLONG_MAX by
> TestArguments.atojulong gtest. Instead of using JULONG_FORMAT, which might not
> be the proper type (though sized properly), use "%llu" to avoid potential
> warning.
> 
> Also changed the test_arguments.cpp file to use os::snprintf instead of
> jio_snprintf, and improved checking the results of those calls.
> 
> Testing: mach5 tier1

Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:

  back out jio_snprintf => os::snprintf

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25927/files
  - new: https://git.openjdk.org/jdk/pull/25927/files/2bde7b43..3ca9157a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25927&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25927&range=00-01

  Stats: 8 lines in 1 file changed: 1 ins; 2 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/25927.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25927/head:pull/25927

PR: https://git.openjdk.org/jdk/pull/25927


More information about the hotspot-runtime-dev mailing list