RFR: 8360178: TestArguments.atojulong gtest has incorrect format string [v2]
David Holmes
dholmes at openjdk.org
Wed Jun 25 04:16:28 UTC 2025
On Tue, 24 Jun 2025 15:23:45 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Please review this fix for the format directive when printing ULLONG_MAX by
>> TestArguments.atojulong gtest. Instead of using JULONG_FORMAT, which might not
>> be the proper type (though sized properly), use "%llu" to avoid potential
>> warning.
>>
>> Also changed the test_arguments.cpp file to use os::snprintf instead of
>> jio_snprintf, and improved checking the results of those calls.
>>
>> Testing: mach5 tier1
>
> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>
> back out jio_snprintf => os::snprintf
Good - and now trivial.
Thanks
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25927#pullrequestreview-2956424786
More information about the hotspot-runtime-dev
mailing list