RFR: 8359436: AOTCompileEagerly should not be diagnostic [v3]

[Aleksey Shipilev]

> A new AOTCompileEagerly flag introduced by [JDK-8355003](https://bugs.openjdk.org/browse/JDK-8355003) is marked as diagnostic. However, this flag guards the experimental feature, that is, whether the existence of AOT profiles should trigger immediate JIT compilation. Therefore, this flag should be at least be "experimental", rather than "diagnostic".
> 
> I don't think it makes sense to elevate this flag to full product flag, since once AOT code caching arrives, this flag would default to true, and would cause AOT loads instead of JIT compilations. Disabling the flag by user choice would be significantly counter-productive then.
> 
> Additional testing:
>  - [x] Linux x86_64 server fastdebug, `runtime/cds`

Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Add bug line
 - Merge branch 'master' into JDK-8359436-aot-diagnostic
 - Merge branch 'master' into JDK-8359436-aot-diagnostic
 - Test
 - Fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25799/files
  - new: https://git.openjdk.org/jdk/pull/25799/files/c62f367f..6b84ae34

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25799&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25799&range=01-02

  Stats: 30773 lines in 831 files changed: 17260 ins; 9201 del; 4312 mod
  Patch: https://git.openjdk.org/jdk/pull/25799.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25799/head:pull/25799

PR: https://git.openjdk.org/jdk/pull/25799