RFR: 8359436: AOTCompileEagerly should not be diagnostic [v2]

Aleksey Shipilev shade at openjdk.org
Wed Jun 25 10:13:49 UTC 2025


On Tue, 17 Jun 2025 14:57:18 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> May be modify `aotProfile/AOTProfileFlags.java` instead.

Would prefer to have it in separate file, for the occasion we remove/modify the flag later.

> test/hotspot/jtreg/runtime/cds/appcds/aotCache/AOTCompileEagerly.java line 1:
> 
>> 1: /*
> 
> There is `aotProfile` directory for training data testing.

I think the connection to training data is not very direct with this flag, so I'll keep it in generic folder.

> test/hotspot/jtreg/runtime/cds/appcds/aotCache/AOTCompileEagerly.java line 27:
> 
>> 25: 
>> 26: /*
>> 27:  * @test
> 
> Missing ` * @bug 8359436`

Added, thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25799#issuecomment-3004206955
PR Review Comment: https://git.openjdk.org/jdk/pull/25799#discussion_r2166348984
PR Review Comment: https://git.openjdk.org/jdk/pull/25799#discussion_r2166347752


More information about the hotspot-runtime-dev mailing list