RFR: 8360178: TestArguments.atojulong gtest has incorrect format string [v2]

[Kim Barrett]

On Wed, 25 Jun 2025 04:12:52 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> The unittest.hpp include is clearly improperly ordered, so should be moved.
>> The question is, where to. It's very common for it to be the last include.
>> And the header itself suggests it is supposed to be last:
>> https://github.com/openjdk/jdk/blob/0514cee6c884b6d31735551b8a3ce7a2be661094/test/hotspot/gtest/unittest.hpp#L46-L47
>> 
>> My recollection is that there used to be documentation (possibly internal or
>> preliminatry during development of gtest support) that it needed to be last.
>> But that doesn't seem to have made it into the public documentation. It was
>> left out of the style guide include order rules because it was still under
>> discussion / investigation.
>
> We should try to get that documented as this arose in another PR last week.

https://bugs.openjdk.org/browse/JDK-8360524

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25927#discussion_r2166647205