RFR: 8360533: ContainerRuntimeVersionTestUtils fromVersionString fails with some docker versions
Martin Doerr
mdoerr at openjdk.org
Thu Jun 26 10:14:27 UTC 2025
On Thu, 26 Jun 2025 09:27:20 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> On Linux ppc64le RHEL 8, we have such a docker version :
>
> docker --version
> Docker version v25.0.3, build 4debf41
>
>
> Unfortunately, the leading 'v' is not expected in ContainerRuntimeVersionTestUtils fromVersionString so we get an exception.
>
> Probably we should simply skip the leading 'v' .
> Also the appended build info has to be considered.
>
> Example failure
>
> TEST: jdk/internal/platform/docker/TestDockerMemoryMetricsSubgroup.java
> TEST RESULT: Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Failed to parse container runtime version: Docker version v25.0.3, build 4debf41
Looks correct. Would be nice to mention the comma in the comment as well.
-------------
Marked as reviewed by mdoerr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25996#pullrequestreview-2961520315
More information about the hotspot-runtime-dev
mailing list