RFR: 8360533: ContainerRuntimeVersionTestUtils fromVersionString fails with some docker versions [v2]
Matthias Baesken
mbaesken at openjdk.org
Fri Jun 27 07:40:43 UTC 2025
On Fri, 27 Jun 2025 05:36:55 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> On Linux ppc64le RHEL 8, we have such a docker version :
>>
>> docker --version
>> Docker version v25.0.3, build 4debf41
>>
>>
>> Unfortunately, the leading 'v' is not expected in ContainerRuntimeVersionTestUtils fromVersionString so we get an exception.
>>
>> Probably we should simply skip the leading 'v' .
>> Also the appended build info has to be considered.
>>
>> Example failure
>>
>> TEST: jdk/internal/platform/docker/TestDockerMemoryMetricsSubgroup.java
>> TEST RESULT: Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Failed to parse container runtime version: Docker version v25.0.3, build 4debf41
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> Update test/lib/jdk/test/lib/containers/docker/ContainerRuntimeVersionTestUtils.java
>
> Co-authored-by: Severin Gehwolf <jerboaa at gmail.com>
Thanks for the reviews !
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25996#issuecomment-3012025794
More information about the hotspot-runtime-dev
mailing list