RFR: 8310831: Some methods are missing from CDS regenerated JLI holder class [v2]

[Calvin Cheung]

On Fri, 27 Jun 2025 18:03:48 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @iklam comments
>
> src/hotspot/share/cds/regeneratedClasses.cpp line 60:
> 
>> 58:     if (regen_m == nullptr) {
>> 59:       ResourceMark rm;
>> 60:       if (strstr(orig_m->external_name(), "$Holder.<init>") == nullptr) {
> 
> I think it's better to use `orig_m->name() != vmSymbols::object_initializer_name()`.
> 
> Also, we should have a comment that explain why it's OK for `<init>` to be skipped.

Fix updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26011#discussion_r2172866982