RFR: 8310831: Some methods are missing from CDS regenerated JLI holder class [v2]

Ioi Lam iklam at openjdk.org
Sat Jun 28 02:06:51 UTC 2025


On Fri, 27 Jun 2025 21:01:54 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Per the [suggested fix](https://bugs.openjdk.org/browse/JDK-8310831?focusedId=14788065&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14788065), this patch doesn't issue a warning if the missing method is the constructor of a holder class.
>> 
>> Sanity tier1 tested.
>> 
>> Manually tested by building the `images` with the `-Xlog:cds=off` removed from the `GenerateLinkOptData.gmk` and with build logging enabled (`LOG=info`).
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @iklam comments

LGTM.

-------------

Marked as reviewed by iklam (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26011#pullrequestreview-2968316385


More information about the hotspot-runtime-dev mailing list