RFR: 8358748: Large page size initialization fails with assert "page_size must be a power of 2" [v2]

[Yagmur Eren]

On Thu, 26 Jun 2025 08:07:29 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Yagmur Eren has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   some fixes
>
> src/hotspot/share/runtime/flags/jvmFlagConstraintsRuntime.cpp line 136:
> 
>> 134:                         "LargePageSizeInBytes ( %zu ) must be "
>> 135:                         "a power of 2\n",
>> 136:                         value);
> 
> Suggestion:
> 
>     JVMFlag::printError(verbose, "LargePageSizeInBytes ( %zu ) must be "
>                         "a power of 2\n", value);

I actually did this in the same format with the other power-of-two example in the same file but this looks better.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25994#discussion_r2174446743