RFR: 8358748: Large page size initialization fails with assert "page_size must be a power of 2" [v2]

[Yagmur Eren]

On Mon, 30 Jun 2025 06:58:22 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> Yagmur Eren has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   some fixes
>
> src/hotspot/share/runtime/flags/jvmFlagConstraintsRuntime.cpp line 141:
> 
>> 139:     return JVMFlag::SUCCESS;
>> 140:   }
>> 141: }
> 
> I don't think you need `else` part here.
> 
> Suggestion:
> 
>   } 
>     
>   return JVMFlag::SUCCESS;
> }

Makes sense. I was trying out stuff and no clue why I left it like this. Thanks for highlighting!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25994#discussion_r2174448281