RFR: 8360743: Enables regeneration of JLI holder classes for CDS static dump [v2]
Calvin Cheung
ccheung at openjdk.org
Mon Jun 30 17:20:40 UTC 2025
On Mon, 30 Jun 2025 16:25:20 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Calvin Cheung has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>>
>> - Merge branch 'master' into 8360743-enables-regen-JLI-holder
>> - 8360743: Enables regeneration of JLI holder classes for CDS static dump
>
> src/hotspot/share/cds/aotArtifactFinder.cpp line 251:
>
>> 249: }
>> 250:
>> 251: InstanceKlass* nest_host = ik->nest_host_or_null();
>
> Just curious, what is this nest host treatment for? I don't think the generated Holder classes have the NestHost attribute, despite them being listed in NestMembers of their top level classes.
This handles the nest host of hidden classes. During investigation, I encountered a null `GenerateJLIClassesHelper` class during dumping and causes a crash. This change, which is suggested by Ioi, fixes the issue.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26007#discussion_r2175552655
More information about the hotspot-runtime-dev
mailing list