RFR: 8360090: [TEST] RISC-V: disable some cds tests on qemu
Leonid Mesnik
lmesnik at openjdk.org
Mon Jun 30 23:12:38 UTC 2025
On Fri, 20 Jun 2025 09:27:14 GMT, Hamlin Li <mli at openjdk.org> wrote:
> Hi,
> Can you help to review this patch?
>
> CDS does not work well in cross compilation env, this is by desgin, please check `JDKOPT_ENABLE_DISABLE_CDS_ARCHIVE` in make of jdk.
>
> These tests depends on classes.jsa or classes_xxx.jsa which is not generated and will not be generated when build jdk in qemu environment for riscv, so we should disable them when qemu.
>
> Thanks!
You can add new property for your condition in VMProps, saying vm.cds.archive.available that is true is archive is generated for JDK. Since the classes.jsa is mandatory the property should check if classes.jsa exists and if current configuration allows to miss classes.jsa. You could start with adding risc+qemu as a first configuration with optional cds archive.
Later it could be extended.
Alternatively you could just throw SkippedException in the tests, assuming that number of them is small. There is an example with isCOHArchiveAvailable() check.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25913#issuecomment-3021115071
More information about the hotspot-runtime-dev
mailing list