RFR: 8359707: Add classfile modification code to RedefineClassHelper [v11]

Leonid Mesnik lmesnik at openjdk.org
Mon Jun 30 23:28:41 UTC 2025


On Mon, 30 Jun 2025 16:49:02 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> I copied this code for another test in the Valhalla repo and thought it would be a good utility function.  It might be better written using the Classfile API.
>> Tested with test.
>
> Coleen Phillimore has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Update test/lib/RedefineClassHelper.java
>    
>    Co-authored-by: David Holmes <62092539+dholmes-ora at users.noreply.github.com>
>  - Update test/lib/RedefineClassHelper.java
>    
>    Co-authored-by: David Holmes <62092539+dholmes-ora at users.noreply.github.com>
>  - Update test/lib/RedefineClassHelper.java
>    
>    Co-authored-by: David Holmes <62092539+dholmes-ora at users.noreply.github.com>

Changes requested by lmesnik (Reviewer).

test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/ClassVersionAfterRedefine.java line 45:

> 43:         ClassVersionAfterRedefine cvar = new ClassVersionAfterRedefine();
> 44: 
> 45:         // Poor man's renaming of class "TestClassOld" to "TestClassXXX"

It is not "poor man's" renaming anymore and RedefineClassHelper.replaceClassName() is self-explanable. So this comment could be just removed.

-------------

PR Review: https://git.openjdk.org/jdk/pull/25857#pullrequestreview-2973056824
PR Review Comment: https://git.openjdk.org/jdk/pull/25857#discussion_r2176137182


More information about the hotspot-runtime-dev mailing list