RFR: 8350584: Check the usage of LOG_PLEASE
Thomas Stuefe
stuefe at openjdk.org
Mon Mar 3 05:35:58 UTC 2025
On Tue, 25 Feb 2025 03:32:30 GMT, SendaoYan <syan at openjdk.org> wrote:
> Hi all,
>
> Seen discussion in https://github.com/openjdk/jdk/pull/23290#issuecomment-2678001782. The LOG_PLEASE macro seems currently being defined are debugging leftovers that shouldn't have been committed. It's definition is typically
> commented or uncommented to provide some additional logging for some tests of interest.
>
> This PR comment out the `#define LOG_PLEASE` same to other gtests. Change has been verified locally, test-fix only, no risk.
This is fine.
-------------
Marked as reviewed by stuefe (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23764#pullrequestreview-2653096082
More information about the hotspot-runtime-dev
mailing list