RFR: 8350567: NMT: update VMATree::register_mapping to copy the existing tag of the region [v2]
Afshin Zafari
azafari at openjdk.org
Mon Mar 3 12:11:42 UTC 2025
On Thu, 27 Feb 2025 09:38:12 GMT, Afshin Zafari <azafari at openjdk.org> wrote:
>> When committing a sub-region (SR) in the middle of a reserved region (RR), we need to decide on the MemTag. To find the correct tag, we had to find the RR base and take the tag and use it for SR.
>> With this PR, there will be no need to find the RR base and the tag of the previous region of SR can be copied to the SR.
>>
>> Tests:
>> linux-x64-debug, gtest:NMT*, runtime/NMT
>
> Afshin Zafari has updated the pull request incrementally with two additional commits since the last revision:
>
> - removed extra whitespace.
> - unit test added.
> It seems like the actual bug is in the summary diff accounting code and _not_ in the actual reservations, see comments. Is that correct?
By removing the unnecessary line of code, yes the bug is only in summary accounting.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23771#issuecomment-2694077236
More information about the hotspot-runtime-dev
mailing list