RFR: 8350567: NMT: update VMATree::register_mapping to copy the existing tag of the region [v2]
Afshin Zafari
azafari at openjdk.org
Mon Mar 3 12:11:42 UTC 2025
On Sun, 2 Mar 2025 20:16:36 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> test/hotspot/gtest/nmt/test_vmatree.cpp line 728:
>>
>>> 726: }
>>> 727:
>>> 728: TEST_VM_F(NMTVMATreeTest, CommitUseFlagInplace) {
>>
>> Change this test to use `expect_equivalent_form`, see other usages to see what should look like. You can add multiple checks even, so that we get how the range changes over time.
>
> Is the bug actually in the summary accounting? If so, I'd like to see a better test name here that indicates that and *not* change this to `expect_equivalent_form` and so on.
New name chosen.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23771#discussion_r1977356624
More information about the hotspot-runtime-dev
mailing list