RFR: 8350623: Fix -Wzero-as-null-pointer-constant warnings in nsk native test utilities

Coleen Phillimore coleenp at openjdk.org
Mon Mar 3 15:01:04 UTC 2025


On Wed, 26 Feb 2025 12:03:27 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this trivial change to remove a use of literal zero as a null
> pointer constant.
> 
> Testing: mach5 tier1
> Locally tested (linux-x64) with -Wzero-as-null-pointer-constant enabled to
> verify the warnings associated with this code were removed.

Looks good plus trivial.

test/hotspot/jtreg/vmTestbase/nsk/share/native/native_thread.cpp line 101:

> 99:     thread->status   = thread->procedure(thread->context);
> 100:     thread->finished = 1;
> 101: #ifdef windows

Lower case 'windows' ??  Not an issue for your change, but odd.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23797#pullrequestreview-2654383830
PR Review Comment: https://git.openjdk.org/jdk/pull/23797#discussion_r1977666497


More information about the hotspot-runtime-dev mailing list