RFR: 8348322: AOT cache creation crashes with "All cached hidden classes must be aot-linkable" when AOTInvokeDynamicLinking is disabled [v3]

[Matias Saavedra Silva]

On Sat, 1 Mar 2025 00:59:23 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> This changeset fixes a crash during AOT cache creation when `AOTInvokeDynamicLinking` is disabled.
>> Changes in `cdsHeapVerifier.cpp` is required to avoid error such as the following during AOT cache creation:
>> 
>> 
>> [4.156s][warning][cds,heap] Archive heap points to a static field that may hold a different value at runtime:
>> [4.156s][warning][cds,heap] Field: java/util/Collections::EMPTY_LIST
>> 
>> Per Ioi's suggestions, added the `CDSConfig::is_dumping_method_handles()` so that most of the calls to `CDSConfig::is_dumping_aot_linked_classes()` and `CDSConfig::is_dumping_invokedynamic()` could be replaced with the new function.
>> 
>> Passed tiers 1 - 3 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @iklam comment

LGTM, thanks!

-------------

Marked as reviewed by matsaave (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23546#pullrequestreview-2654397494