RFR: 8350854: Include thread counts in safepoint logging
Aleksey Shipilev
shade at openjdk.org
Tue Mar 4 13:23:54 UTC 2025
On Tue, 4 Mar 2025 08:19:34 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote:
>> src/hotspot/share/runtime/safepoint.cpp line 993:
>>
>>> 991: "Leaving safepoint: " JLONG_FORMAT " ns, "
>>> 992: "Total: " JLONG_FORMAT " ns, "
>>> 993: "Threads: " INT32_FORMAT " runnable, " INT32_FORMAT " total",
>>
>> Why `INT32_FORMAT` when the fields are just `int`???
>
> Hi David, thanks for the review, I referred to the format used in safepoint [stats log](https://github.com/openjdk/jdk/pull/23838/files#diff-d61020d12394708828d066d097d823180c01b74d35d4c3e369aead062abc11efR913) where format `INT32_FORMAT_W(8)` is used for thread counts, but there is no need print thread count in fixed width with safepoint log, so I removed the fixed width from the format.
The question now is, why not just `%d` then?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23838#discussion_r1979423234
More information about the hotspot-runtime-dev
mailing list