RFR: 8351046: Rename ObjectMonitor functions [v2]
Coleen Phillimore
coleenp at openjdk.org
Mon Mar 10 12:38:53 UTC 2025
On Mon, 10 Mar 2025 07:09:03 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Typo in sed script.
>
> src/hotspot/share/runtime/objectMonitor.cpp line 1191:
>
>> 1189:
>> 1190: if (node->is_wait() && !node->at_reenter()) {
>> 1191: bool acquired_monitor = vthread_waitReenter(current, node, cont);
>
> Should this be vthread_wait_reenter?
Thank you for seeing this. I've changed that one too. There are still a couple of data members with mixed names. _WaitSet, _WaitSetMonitor and _SpinDuration. Should I change them too?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23450#discussion_r1987201137
More information about the hotspot-runtime-dev
mailing list