RFR: 8351382: New test containers/docker/TestMemoryWithSubgroups.java is failing [v2]
Severin Gehwolf
sgehwolf at openjdk.org
Tue Mar 11 10:01:10 UTC 2025
On Tue, 11 Mar 2025 00:53:34 GMT, Sergey Chernyshev <schernyshev at openjdk.org> wrote:
>> The new test fails in rootless Docker mode after [JDK-8343191](https://bugs.openjdk.org/browse/JDK-8343191):
>>
>> containers/docker/TestMemoryWithSubgroups.java
>>
>> [STDERR]
>>
>> Resource limits are not supported and ignored on cgroups V1 rootless systems
>>
>> [STDOUT]
>>
>> mkdir: cannot create directory '/sys/fs/cgroup/memory/test': Permission denied
>> sh: /sys/fs/cgroup/memory/test/memory.limit_in_bytes: No such file or directory
>> sh: /sys/fs/cgroup/memory/test/cgroup.procs: No such file or directory
>>
>> The test TestMemoryWithSubgroups.java uses `--privileged` mode to modify process' cgroup, that has no effect in rootless mode. The test has to be skiped.
>>
>> The fix is to query `info -f {{println .SecurityOptions}}` and check whether it has `name=rootless` in the output.
>
> Sergey Chernyshev has updated the pull request incrementally with one additional commit since the last revision:
>
> addressed review comment
Looks fine to me. I haven't tested the rootless docker setup, though. So perhaps this should go through Oracle's CI before integrating.
-------------
Marked as reviewed by sgehwolf (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23948#pullrequestreview-2673708923
More information about the hotspot-runtime-dev
mailing list