RFR: 8351651: Cleanup LockStack::is_owning_thread

Stefan Karlsson stefank at openjdk.org
Tue Mar 11 12:56:55 UTC 2025


On Tue, 11 Mar 2025 12:15:15 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> This is a minor mostly trivial change I found while reading through code looking for something else.
> Tested with tier1-4.

Is this change really that important? It looks like this is a small optimization for non-product verification code. Why do we need to micro optimize that?

Or did I miss some subtle part that makes this look cleaner? Could you explain why this is cleaner?

src/hotspot/share/runtime/synchronizer.cpp line 413:

> 411:     return LightweightSynchronizer::quick_enter(obj, lock, current);
> 412:   }
> 413: 

This looks unrelated.

-------------

PR Review: https://git.openjdk.org/jdk/pull/23981#pullrequestreview-2674348756
PR Review Comment: https://git.openjdk.org/jdk/pull/23981#discussion_r1989189319


More information about the hotspot-runtime-dev mailing list