RFR: 8351651: Cleanup LockStack::is_owning_thread [v3]

[Stefan Karlsson]

On Tue, 11 Mar 2025 13:05:12 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/runtime/synchronizer.cpp line 413:
>> 
>>> 411:     return LightweightSynchronizer::quick_enter(obj, lock, current);
>>> 412:   }
>>> 413: 
>> 
>> This looks unrelated.
>
> It is unrelated, but I mentioned it in the bug report.  Feels like too useless to do on it's own.

I didn't read the bug report with the anticipation that the PR description had all the necessary information.

I was surprised by this change in a bug named "Cleanup LockStack::is_owning_thread" and I think that future readers might be as well. So, I prefer if you split this into a separate PR. PRs are fast to create nowadays. If you don't want to do that, then at least update the name of the PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23981#discussion_r1989267935