RFR: 8351651: Cleanup LockStack::is_owning_thread [v3]

Stefan Karlsson stefank at openjdk.org
Tue Mar 11 13:34:09 UTC 2025


On Tue, 11 Mar 2025 13:14:20 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This is a minor mostly trivial change I found while reading through code looking for something else.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed cast, compiled out is_owning_thread.

src/hotspot/share/runtime/lockStack.cpp line 82:

> 80:  bool is_owning = &current->lock_stack() == this;
> 81:  assert(is_owning == (get_thread() == current), "is_owning sanity");
> 82:  return is_owning;

Suggestion:

  bool is_owning = &current->lock_stack() == this;
  assert(is_owning == (get_thread() == current), "is_owning sanity");
  return is_owning;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23981#discussion_r1989286749


More information about the hotspot-runtime-dev mailing list