RFR: 8351651: Cleanup LockStack::is_owning_thread [v5]

[Stefan Karlsson]

On Tue, 11 Mar 2025 16:17:43 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This is a minor mostly trivial change I found while reading through code looking for something else.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Restore lightweight case and removed NOT_PRODUCT.

So, now you have declared but not defined this function in product builds, which means that the next person that will try to use the function in a product context will hit a linker error. That's not really what I proposed.

I think you need to choose if you want to go with my preferred solution and make this a fully declared and defined product function, or revert back to completely compiling out the function as you did in an earlier version. I prefer the former, the latter is OK, but the current version is confusing.

-------------

PR Review: https://git.openjdk.org/jdk/pull/23981#pullrequestreview-2676143912